[PATCH] D149083: [PowerPC] Optimize VPERM and fix code order for swapping vector operands on LE
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 24 05:35:14 PDT 2023
stefanp added a comment.
I think the patch mostly looks good. I have one more minor comment.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10345
+
+ if (isPPC64 && (V1HasXXSWAPD || V2HasXXSWAPD || Opcode == PPCISD::XXPERM)) {
+ if (ValType != MVT::v2f64)
----------------
Since you have removed `Opcode == PPCISD::XXPERM` from other places in the code is it safe to remove it from here as well?
Sorry, I know that I suggested it be written like this but looking at how the condition has been removed everywhere else it makes sense to me to remove this one as well..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149083/new/
https://reviews.llvm.org/D149083
More information about the llvm-commits
mailing list