[PATCH] D158609: [LICM][LoopSimplify] Create preheader for callbr (PR64215)

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D158609#4610264 <https://reviews.llvm.org/D158609#4610264>, @nickdesaulniers wrote:

> Thanks for the patch!
> Any other call sites of `Instruction::isExceptionalTerminator()` that might need similar touch ups?  Perhaps we should just add `Instruction::CallBr` to `isExceptionalTerminator(unsigned OpCode)`?

Good point. For example this test crashes jump-threading:

  define i32 @test() {
    %x = callbr i32 asm sideeffect "", "=r"()
    to label %bb []
  
  bb:
    ret i32 %x
  }

So yeah, I think we should add it and rename the method, though I'm not sure to what.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158609/new/

https://reviews.llvm.org/D158609