[PATCH] D158399: [WebAssembly] Optimize vector shift using a splat value from outside block

Yolanda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 03:11:07 PDT 2023


YolandaCY added a comment.

In D158399#4607933 <https://reviews.llvm.org/D158399#4607933>, @craig.topper wrote:

> Could this use the `TargetLowering::shouldSinkOperands` hook to get CodeGenPrepare to move the splat into the loop. ARM, X86, and RISC-V all do that.

Thanks for the suggestion! I have revised the code to use this existing hook. Please help take a look again. @craig.topper @tlively Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158399/new/

https://reviews.llvm.org/D158399



More information about the llvm-commits mailing list