[PATCH] D158256: [RISCV] Fix assertion failure when zcmp extension is enabled.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/frame-lowering-crash.ll:1
+; RUN: llc -mattr=+zcmp -verify-machineinstrs  \
+; RUN: -mtriple=riscv32 -target-abi ilp32 < %s \
----------------
Can we decide a single name for the test files? Either frame-lowering-crash.ll/mir or prolog-epilog-crash.mir?

Maybe worth including zcmp in the test file name too?


================
Comment at: llvm/test/CodeGen/RISCV/frame-lowering-crash.ll:13
+
+declare hidden void @f1() local_unnamed_addr
+define hidden void @f0() local_unnamed_addr {
----------------
Do we need the hidden and local_unnamed_addr attributes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158256/new/

https://reviews.llvm.org/D158256