[PATCH] D158681: [FunctionPropertiesAnalysis] Add CFG and call properties

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:118
+        CriticalEdgeCount += Direction;
+    }
+
----------------
jdoerfert wrote:
> This counts each critical edge #predecessors times, doesn't it?
Yes. I forgot to add the conditional that the number of successors of the block must be greater than zero. Fixed in the latest patch (with a test case added).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158681/new/

https://reviews.llvm.org/D158681