[PATCH] D158576: [GlobalISel] Copy the implementation of SubtargetFeature and use it for PredicateBitset.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 17:33:57 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/ADT/Bitset.h:59
+  constexpr Bitset &set(unsigned I) {
+    // GCC <6.2 crashes if this is written in a single statement.
+    BitWord NewBits = Bits[I / BITWORD_SIZE] | (BitWord(1) << (I % BITWORD_SIZE));
----------------
The unneeded workaround was copied. I created https://reviews.llvm.org/D158687 as a cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158576/new/

https://reviews.llvm.org/D158576



More information about the llvm-commits mailing list