[PATCH] D157388: [AMDGPU] Support FMin/FMax in AMDGPUAtomicOptimizer.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/global_atomic_optimizer_fp_rtn.ll:809
+; IR-DPP-NEXT:    [[TMP18:%.*]] = select i1 [[TMP9]], float 0xFFF0000000000000, float [[VAL]]
+; IR-DPP-NEXT:    [[TMP19:%.*]] = call float @llvm.maxnum.f32(float [[TMP16]], float [[TMP18]])
+; IR-DPP-NEXT:    br label [[TMP20]]
----------------
This broke the strictfp handling (I thought this was supposed to fail the verifier now?)

You probably need something like

```
  Builder.setIsFPConstrained(
      RMWI->getFunction()->hasFnAttribute(Attribute::StrictFP));
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157388/new/

https://reviews.llvm.org/D157388