[PATCH] D158681: [FunctionPropertiesAnalysis] Add CFG and call properties

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:118
+        CriticalEdgeCount += Direction;
+    }
+
----------------
This counts each critical edge #predecessors times, doesn't it?


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:147-150
+        if (Call->getType()->isFloatingPointTy())
+          CallReturnsFloatCount += Direction;
+        if (Call->getType()->isPointerTy())
+          CallReturnsPointerCount += Direction;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158681/new/

https://reviews.llvm.org/D158681