[PATCH] D158675: [NFC][AsmPrinter] Refactor DbgVariable as a std::variant
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 23 15:46:56 PDT 2023
scott.linder added a comment.
I've had this patch series sitting around for a little bit, and when I rebased I noted that there was now a comment from @fdeazeve explicitly pointing out that something like this refactoring would be nice, so I finally got around to cleaning it up and pushing it. Let me know what you think!
I broke things up to give a few different options for where to "stop", in case there was aversion to changing the interface fundamentally. I think the final result of the series is both easier to read and has potential performance benefits, but I'd love to hear feedback on either part.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158675/new/
https://reviews.llvm.org/D158675
More information about the llvm-commits
mailing list