[PATCH] D158598: [RFC][GlobalISel] Remove const from most MatchTableExecutor methods
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 23 15:32:21 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h:102
bool selectG_FMA_FMAD(MachineInstr &I) const;
- bool selectG_MERGE_VALUES(MachineInstr &I) const;
+ bool selectG_MERGE_VALUES(MachineInstr &I);
bool selectG_UNMERGE_VALUES(MachineInstr &I) const;
----------------
I'm not seeing the context how this helps. I think things should be kept const, especially since all the others here are
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158598/new/
https://reviews.llvm.org/D158598
More information about the llvm-commits
mailing list