[PATCH] D156853: [AMDGPU] Add metadata to track preloaded arguments

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp:175-182
+      MDBuilder MDB(Ctx);
+      auto *MDIndex =
+          MDB.createConstant(llvm::ConstantInt::get(Builder.getInt32Ty(), Idx));
+      auto *MDAllocSizeSGPRs = MDB.createConstant(
+          llvm::ConstantInt::get(Builder.getInt32Ty(), PreloadSGPRs));
+      PreloadInfo.KernelArgMetadata.push_back(
+          llvm::MDNode::get(Ctx, {MDIndex, MDAllocSizeSGPRs}));
----------------
Don't understand why you need to read, much less create new metadata here


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:148-155
-    if (!F.hasFnAttribute("amdgpu-no-dispatch-ptr"))
-      DispatchPtr = true;
-
-    if (!F.hasFnAttribute("amdgpu-no-queue-ptr"))
-      QueuePtr = true;
-
-    if (!F.hasFnAttribute("amdgpu-no-dispatch-id"))
----------------
Can you split this refactoring into a separate NFC patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156853/new/

https://reviews.llvm.org/D156853