[PATCH] D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:12479-12480
+
+    const auto &CastAAPointerInfoFloating =
+        static_cast<const AAPointerInfoFloating &>(*PI);
+    const auto &AAPointerInfoState = CastAAPointerInfoFloating.getState();
----------------
As I said before, no casting to implementations of the interface. put the method you need into AAPointerInfo.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:12528-12530
+    int NumBytesToAllocate = FixedAllocatedSizeInBits / 8;
+    if (FixedAllocatedSizeInBits % 8 != 0)
+      NumBytesToAllocate += 1;
----------------



================
Comment at: llvm/test/Transforms/Attributor/value-simplify-local-remote.ll:384
-; TUNIT-NEXT:    [[TRUETMP18:%.*]] = icmp eq i32 [[X]], 0
-; TUNIT-NEXT:    br i1 [[TRUETMP18]], label [[BB35:%.*]], label [[BB19:%.*]]
 ; TUNIT:       bb19:
----------------
unrelated, just keep the old version of this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157068/new/

https://reviews.llvm.org/D157068