[PATCH] D154805: [DAGCombiner] Fold IEEE `fmul`/`fdiv` by Pow2 to `add`/`sub` of exp

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 14:38:25 PDT 2023


goldstein.w.n added a comment.

In D154805#4611715 <https://reviews.llvm.org/D154805#4611715>, @arsenm wrote:

> In D154805#4610773 <https://reviews.llvm.org/D154805#4610773>, @RKSimon wrote:
>
>> @arsenm Do you have any more feedback?
>
> I think you're worse off doing this if ldexp is legal (not that we have the combine to form ldexp here)

why is that? ldexp gets lowered as mul/div and its not really possible to transform ldexp into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154805/new/

https://reviews.llvm.org/D154805



More information about the llvm-commits mailing list