[PATCH] D157037: [VPlan] Proactively create mask for tail-folding up-front (NFCI).

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8042
 
+void VPRecipeBuilder::createHeaderMask(VPlan &Plan) {
+  BasicBlock *Header = OrigLoop->getHeader();
----------------
Ayal wrote:
> nit: reorder implementations of createHeaderMask() and createBlockInMask(), matching the reordering of their declarations.
Fixed in the committed version, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8777
 
+  // Proactively create header. Masks for other blocks are created on demand.
+  RecipeBuilder.createHeaderMask(*Plan);
----------------
Ayal wrote:
> 
Fixed in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157037/new/

https://reviews.llvm.org/D157037