[PATCH] D154604: [BOLT] Calculate output values using BOLTLinker

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 13:02:49 PDT 2023


maksfb added a comment.

LGTM. Could you please add a test case using `.space`/`.skip` asm directive to trigger the linker relaxation on RISC-V?

Also, the summary might use an update after the rebase on D155604 <https://reviews.llvm.org/D155604>.



================
Comment at: bolt/include/bolt/Rewrite/JITLinkLinker.h:38
   std::vector<ExecutableFileMemoryManager::FinalizedAlloc> Allocs;
-  std::map<std::string, uint64_t> Symtab;
+  std::map<std::string, SymbolInfo> Symtab;
 
----------------
Use ADT's `StringMap` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154604/new/

https://reviews.llvm.org/D154604



More information about the llvm-commits mailing list