[PATCH] D158250: [IR] Add more details to StructuralHash

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.

Looks fine. Please test EXPENSIVE_ CHECKS to make sure this doesn't find new missing invalidations.



================
Comment at: llvm/lib/IR/StructuralHash.cpp:40
+  // TODO: Refactor this to be a hash_value implementation within
+  // Type.
+  void hashType(Type *ValueType) {
----------------
I don't think we should add hash_value implementations to uniqued types. It encourages misuse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158250/new/

https://reviews.llvm.org/D158250