[PATCH] D158317: [IR] Add SturcturalHash printer pass

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/test/Analysis/StructuralHash/structural-hash-printer.ll:20
+; DETAILED-HASH: Function f1 Hash: 7c3de1848de089eb
+; DETAILED-HASH: Function f2 Hash: e8f145a33b501984
+
----------------
nikic wrote:
> Isn't this going to fail on 32-bit, at least when combined with your other patch?
Yes. I meant to fix this but hadn't gotten around to it yet. I've split the test into two files, one marked as `REQUIRE; llvm-64-bits`. I check both hashes on both platforms (but regex for the detailed hash on the non-64-bit-only test) and check for an exact hash on the 64 bit platform. I think that should provide a decent amount of test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158317/new/

https://reviews.llvm.org/D158317