[PATCH] D157955: [TableGen] Make OpcodeMappings sort comparator strict weak ordering compliant

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 10:27:44 PDT 2023


andrewng added a comment.

Sorry, but I'm quite busy right now and I haven't had a chance to look into this in detail. At a glance, I believe that the code here is OK because `LessThan` is always used after inequality has already been established. However, I agree that `LessThan` itself is not a "complete" `<` operator but I don't think it needs to be in this use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157955/new/

https://reviews.llvm.org/D157955



More information about the llvm-commits mailing list