[PATCH] D158462: [OMPIRBuilder] Fix shared clause for task construct

[Prabhdeep Soni via Phabricator via llvm-commits]

psoni2628 added a comment.

In D158462#4610054 <https://reviews.llvm.org/D158462#4610054>, @psoni2628 wrote:

> In D158462#4609718 <https://reviews.llvm.org/D158462#4609718>, @kiranchandramohan wrote:
>
>> Thanks @psoni2628 for the patch. This is great.
>> Could you upload the patch with full context for ease of review?
>> Are the Clang OpenMP test failures related?
>
> Yes. So for context, the following Fortran test case was failing previously, but now it runs.
>
>   subroutine foo()
>     implicit none
>     integer::x,y
>     x=0
>      !$omp task shared(x,y)
>      x=2
>      y=3
>   
>      !$omp end task
>     !$omp taskwait        
>     print *, x, y
>   end subroutine foo
>   
>   program p
>   implicit none
>   
>   !$omp parallel
>   !$omp single
>   call foo()
>   !$omp end single
>   !$omp end parallel
>   end program p
>
> As for the clang failures, it looks like they are related. I think I just need to update the CHECK lines, but I'm still figuring that out.



In D158462#4610054 <https://reviews.llvm.org/D158462#4610054>, @psoni2628 wrote:

> In D158462#4609718 <https://reviews.llvm.org/D158462#4609718>, @kiranchandramohan wrote:
>
>> Thanks @psoni2628 for the patch. This is great.
>> Could you upload the patch with full context for ease of review?
>> Are the Clang OpenMP test failures related?
>
> Yes. So for context, the following Fortran test case was failing previously, but now it runs.
>
>   subroutine foo()
>     implicit none
>     integer::x,y
>     x=0
>      !$omp task shared(x,y)
>      x=2
>      y=3
>   
>      !$omp end task
>     !$omp taskwait        
>     print *, x, y
>   end subroutine foo
>   
>   program p
>   implicit none
>   
>   !$omp parallel
>   !$omp single
>   call foo()
>   !$omp end single
>   !$omp end parallel
>   end program p
>
> As for the clang failures, it looks like they are related. I think I just need to update the CHECK lines, but I'm still figuring that out.



In D158462#4610148 <https://reviews.llvm.org/D158462#4610148>, @kiranchandramohan wrote:

> In D158462#4610054 <https://reviews.llvm.org/D158462#4610054>, @psoni2628 wrote:
>
>> In D158462#4609718 <https://reviews.llvm.org/D158462#4609718>, @kiranchandramohan wrote:
>>
>>> Thanks @psoni2628 for the patch. This is great.
>>> Could you upload the patch with full context for ease of review?
>>> Are the Clang OpenMP test failures related?
>>
>> Yes. So for context, the following Fortran test case was failing previously, but now it runs.
>>
>>   subroutine foo()
>>     implicit none
>>     integer::x,y
>>     x=0
>>      !$omp task shared(x,y)
>>      x=2
>>      y=3
>>   
>>      !$omp end task
>>     !$omp taskwait        
>>     print *, x, y
>>   end subroutine foo
>>   
>>   program p
>>   implicit none
>>   
>>   !$omp parallel
>>   !$omp single
>>   call foo()
>>   !$omp end single
>>   !$omp end parallel
>>   end program p
>>
>> As for the clang failures, it looks like they are related. I think I just need to update the CHECK lines, but I'm still figuring that out.
>
> @psoni2628 By context, i meant showing the full diff for the files where changes are made.
>
>   To get a full diff, use one of the following commands (or just use Arcanist to upload your patch):
>   
>   git show HEAD -U999999 > mypatch.patch
>   git diff -U999999 @{u} > mypatch.patch
>   git diff HEAD~1 -U999999 > mypatch.patch

Done. I forgot to do that, sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158462/new/

https://reviews.llvm.org/D158462