[PATCH] D158462: [OMPIRBuilder] Fix shared clause for task construct

Prabhdeep Soni via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 07:30:22 PDT 2023


psoni2628 added a comment.

In D158462#4609718 <https://reviews.llvm.org/D158462#4609718>, @kiranchandramohan wrote:

> Thanks @psoni2628 for the patch. This is great.
> Could you upload the patch with full context for ease of review?
> Are the Clang OpenMP test failures related?

Yes. So for context, the following Fortran test case was failing previously, but now it runs.

  subroutine foo()
    implicit none
    integer::x,y
    x=0
     !$omp task shared(x,y)
     x=2
     y=3
  
     !$omp end task
    !$omp taskwait        
    print *, x, y
  end subroutine foo
  
  program p
  implicit none
  
  !$omp parallel
  !$omp single
  call foo()
  !$omp end single
  !$omp end parallel
  end program p

As for the clang failures, it looks like they are related. I think I just need to update the CHECK lines, but I'm still figuring that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158462/new/

https://reviews.llvm.org/D158462



More information about the llvm-commits mailing list