[PATCH] D157210: [symbolizer] Change reaction on invalid input

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff updated this revision to Diff 552686.
sepavloff added a comment.

Attempt to make llvm-symbolizer more hang-resistant

Behavior of llvm-symbolizer is slightly modified to avoid hanging.
If it receives data from the standard input, it always prints some
output on stdout. If the command is invalid, it prints ??:0 in
addition to the diagnostic on stderr. If a user makes blocking
read of llvm-symbolizer stdout, it won't wait forever with the
updated utility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157210/new/

https://reviews.llvm.org/D157210

Files:
  llvm/docs/CommandGuide/llvm-symbolizer.rst
  llvm/docs/ReleaseNotes.rst
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/test/Support/interrupts.test
  llvm/test/tools/llvm-symbolizer/debuginfod.test
  llvm/test/tools/llvm-symbolizer/file-prefix.test
  llvm/test/tools/llvm-symbolizer/flag-grouping.test
  llvm/test/tools/llvm-symbolizer/flush-output.s
  llvm/test/tools/llvm-symbolizer/functions.s
  llvm/test/tools/llvm-symbolizer/input-base.test
  llvm/test/tools/llvm-symbolizer/invalid-input-address.test
  llvm/test/tools/llvm-symbolizer/options-from-env.test
  llvm/test/tools/llvm-symbolizer/output-style-empty-line.test
  llvm/test/tools/llvm-symbolizer/output-style-json-code.test
  llvm/test/tools/llvm-symbolizer/output-style-json-data.test
  llvm/test/tools/llvm-symbolizer/output-style-json-frame.ll
  llvm/test/tools/llvm-symbolizer/sym-verbose.test
  llvm/test/tools/llvm-symbolizer/sym.test
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157210.552686.patch
Type: text/x-patch
Size: 31793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230823/3f9fc40b/attachment.bin>