[PATCH] D158568: [TableGen] Rename ResourceCycles and StartAtCycle to clarify semantics

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.

Thank you for doing this @michaelmaitland.

Patch looks great. Just one minor thing. I believe there is a typo all across the patch: it should be `Acquire`, not `Aquire`.

Francesco



================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:660
+  /// X0 X1 X1 X2    +--------+-------------+--------------+
+  ///                |Resource|AquireAtCycle|ReleaseAtCycle|
+  ///                +--------+-------------+--------------+
----------------



================
Comment at: llvm/include/llvm/Target/TargetSchedule.td:257
   list<ProcResourceKind> ProcResources = resources;
-  list<int> ResourceCycles = [];
-  list<int> StartAtCycles = [];
+  /// Cycle at which the resource will be released by an instruction,
+  /// relatively to the cycle in which the instruction is issued
----------------
This is very useful, thank you.


================
Comment at: llvm/test/TableGen/AquireAtCycle.td:1
 // RUN: llvm-tblgen -gen-subtarget -DCORRECT -I %p/../../include %s 2>&1 | \
 // RUN:   FileCheck %s  --check-prefix=CORRECT
----------------
File name has typo too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158568/new/

https://reviews.llvm.org/D158568