[PATCH] D158598: [RFC][GlobalISel] Remove const from most MatchTableExecutor methods

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh created this revision.
Pierre-vh added reviewers: arsenm, foad, aemerson.
Herald added subscribers: luke, sunshaoce, pmatos, StephenFan, frasercrmck, ThomasRaoux, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, kbarton, hiraditya, arichardson, jvesely, nemanjai, sdardis.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, MaskRay, wdng.
Herald added a reviewer: zuban32.
Herald added a reviewer: mpaszkowski.
Herald added a project: LLVM.

It's an internal API, there is no need to have const functions.
We often unintentionally work around constness anyway by using `T&` data members which can be modified in `const` functions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158598

Files:
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutorImpl.h
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AArch64/GISel/AArch64O0PreLegalizerCombiner.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PreLegalizerCombiner.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp
  llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp
  llvm/lib/Target/ARM/ARMInstructionSelector.cpp
  llvm/lib/Target/M68k/GISel/M68kInstructionSelector.cpp
  llvm/lib/Target/Mips/MipsInstructionSelector.cpp
  llvm/lib/Target/Mips/MipsPostLegalizerCombiner.cpp
  llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp
  llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp
  llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
  llvm/lib/Target/X86/X86InstructionSelector.cpp
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table-permutations.td
  llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table.td
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/utils/TableGen/GlobalISelCombinerMatchTableEmitter.cpp
  llvm/utils/TableGen/GlobalISelEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.cpp
  llvm/utils/TableGen/GlobalISelMatchTableExecutorEmitter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158598.552666.patch
Type: text/x-patch
Size: 29172 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230823/76dba8ca/attachment.bin>