[PATCH] D157037: [VPlan] Proactively create mask for tail-folding up-front (NFCI).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 04:30:26 PDT 2023


Ayal added a comment.

Couple of minor nits.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8042
 
+void VPRecipeBuilder::createHeaderMask(VPlan &Plan) {
+  BasicBlock *Header = OrigLoop->getHeader();
----------------
nit: reorder implementations of createHeaderMask() and createBlockInMask(), matching the reordering of their declarations.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8777
 
+  // Proactively create header. Masks for other blocks are created on demand.
+  RecipeBuilder.createHeaderMask(*Plan);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157037/new/

https://reviews.llvm.org/D157037



More information about the llvm-commits mailing list