[PATCH] D158177: [RISCV] Optimize floating point scalar move and splat

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 03:58:01 PDT 2023


rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.

Just a minor nit above.

Looks reasonable to me. Thanks, Philip.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:210
+        1,      // SEW can be changed as long as it's greater
+                // than or equal to the original value, but must be less
+    SEWNone = 0 // We don't need to preserve SEW at all.
----------------
The sentence in the comment seems incomplete I think that //"than 64"// might be missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158177/new/

https://reviews.llvm.org/D158177



More information about the llvm-commits mailing list