[llvm] 9173cab - [dsymutil][DWARFv5] Do output verification for DWARFv5.

Alexey Lapshin via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 03:27:34 PDT 2023


Author: Alexey Lapshin
Date: 2023-08-23T12:26:39+02:00
New Revision: 9173cab625f9dfb60a6e4c45094537b205bf10c5

URL: https://github.com/llvm/llvm-project/commit/9173cab625f9dfb60a6e4c45094537b205bf10c5
DIFF: https://github.com/llvm/llvm-project/commit/9173cab625f9dfb60a6e4c45094537b205bf10c5.diff

LOG: [dsymutil][DWARFv5] Do output verification for DWARFv5.

It looks like current support for DWARFv5 is good enough to have
output verification. This patch removes DWARFv5 restriction for
output verification.

Differential Revision: https://reviews.llvm.org/D158508

Added: 
    

Modified: 
    llvm/tools/dsymutil/dsymutil.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 04dfc9cce59f11..49a3541e9ae78f 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -517,10 +517,11 @@ static bool verifyOutput(StringRef OutputFile, StringRef Arch,
   Binary &Binary = *BinOrErr.get().getBinary();
   if (auto *Obj = dyn_cast<MachOObjectFile>(&Binary)) {
     std::unique_ptr<DWARFContext> DICtx = DWARFContext::create(*Obj);
-    if (DICtx->getMaxVersion() >= 5) {
+    if (DICtx->getMaxVersion() > 5) {
       std::lock_guard<std::mutex> Guard(Mutex);
-      WithColor::warning() << "verification skipped for " << Arch
-                           << " because DWARFv5 is not fully supported yet.\n";
+      WithColor::warning()
+          << "verification skipped for " << Arch
+          << " because DWARF standard greater than v5 is not supported yet.\n";
       return true;
     }
 


        


More information about the llvm-commits mailing list