[PATCH] D158449: [IR]Add NumSrcElts param to is..Mask static function in ShuffleVectorInst.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/IR/Instructions.h:2107
   /// Example: <7,5,undef,7>
   /// This assumes that vector operands are the same length as the mask.
+  static bool isSingleSourceMask(ArrayRef<int> Mask, int NumSrcElts);
----------------
Update this comment


================
Comment at: llvm/include/llvm/IR/Instructions.h:2201
   /// Example: <7,6,undef,4>
   /// This assumes that vector operands are the same length as the mask.
+  static bool isReverseMask(ArrayRef<int> Mask, int NumSrcElts);
----------------
Update comment


================
Comment at: llvm/include/llvm/IR/Instructions.h:2221
   /// Example: <4,undef,undef,4>
   /// This assumes that vector operands are the same length as the mask.
+  static bool isZeroEltSplatMask(ArrayRef<int> Mask, int NumSrcElts);
----------------
Update comment


================
Comment at: llvm/include/llvm/IR/Instructions.h:2292
   /// inputs together and then extracts an original width vector starting from
   /// the splice index.
   /// Example: shufflevector <4 x n> A, <4 x n> B, <1,2,3,4>
----------------
Update comment


================
Comment at: llvm/unittests/IR/ShuffleVectorInstTest.cpp:14
 
 namespace {
 
----------------
All of these tests need support for length changing shuffles


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158449/new/

https://reviews.llvm.org/D158449