[PATCH] D158575: [RISCV] Delete deprecated attributes

Xiao Zeng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 00:50:22 PDT 2023


zeng-xiao added a comment.

In D158575#4609157 <https://reviews.llvm.org/D158575#4609157>, @MaskRay wrote:

> These are deprecated, not removed. lld needs to handle old object files with these attributes. The integrated assembler needs to support the syntax in case there are files using these directives.
> I think we can only remove them when the compatibility with these object files/assembly files are deemed unnecessary. I am not sure when we claim to do that.

Okay, I understand what you mean. To be compatible with old elf files, these attributes in risc-v cannot be removed at this time. Perhaps one day in the future, we need to do this work.
This is my first llvm patch, and there will be other patches in the future.
Thank you, Professor Song's comment.
By the way, I am your fan. It's really surprising to have a conversation with you in this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158575/new/

https://reviews.llvm.org/D158575



More information about the llvm-commits mailing list