[PATCH] D150079: [BPF][DebugInfo] Show CO-RE relocations in llvm-objdump

Tue Aug 22 21:09:33 PDT 2023

MaskRay added a comment.

In D150079#4604044 <https://reviews.llvm.org/D150079#4604044>, @eddyz87 wrote:

> Hi @MaskRay ,
>
> If you have some time, could you please take a look?

Sorry, was pretty busy handling a backlog of reviews and day work... Feel free to ping after a week https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted

In a `-DBUILD_SHARED_LIBS=on` build, I get `ld.lld: error: undefined symbol: llvm::BTFParser::parse(llvm::object::ObjectFile const&, llvm::BTFParser::ParseOptions const&)`. We need

  --- i/llvm/tools/llvm-objdump/CMakeLists.txt
  +++ w/llvm/tools/llvm-objdump/CMakeLists.txt
  @@ -5,2 +5,3 @@ set(LLVM_LINK_COMPONENTS
     BinaryFormat
  +  DebugInfoBTF
     DebugInfoDWARF

https://github.com/MaskRay/Config/wiki/LLVM#build-modes Personally, when I make CMake changes, I'll check both the default config and `-DBUILD_SHARED_LIBS=on`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150079/new/

https://reviews.llvm.org/D150079