[PATCH] D158577: [MC,AArch64] Suppress local symbol to STT_SECTION conversion for GOT relocations

Tue Aug 22 20:23:21 PDT 2023

MaskRay added a comment.

Note:

Having both `MCValue` and `MCSymbol` parameters in

  bool needsRelocateWithSymbol(const MCValue &Val, const MCSymbol &Sym,
                               unsigned Type) const override;

is unfortunately due to `.weakref` handling. To not affect `.weakref` behavior (strange directive, see https://sourceware.org/pipermail/binutils/2020-June/111676.html) on Mips/PowerPC, we need `const MCSymbol &Sym`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158577/new/

https://reviews.llvm.org/D158577