[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests
Aditya Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 17:06:31 PDT 2023
hiraditya created this revision.
hiraditya added reviewers: bogner, kadircet.
Herald added subscribers: arphaman, emaste.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer: jhenderson.
Herald added a project: All.
hiraditya requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay, ilya-biryukov.
Herald added a project: LLVM.
Keeping the default value ON to preserve the current behavior
Motivation:
Some of the clangd (TUSchedulerTests) tests intermittently fails in our
internal builders. There are no internal changes to clang-tools-extra
directory in the llvm fork. Either the test times out or it fails with mismatches.
A typical output of `ninja check-clang-tools`
out/llvm-project/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1354: Failure
Value of: S.blockUntilIdle(timeoutSeconds(10))
Actual: false
Expected: true
Built preamble of size 207320 for file /clangd-test/foo.cpp version 3 in 5.44 seconds
Reusing preamble version 3 for version 4 of /clangd-test/foo.cpp
out/llvm-project/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1318: Failure
Value of: Collector.diagVersions().back()
Expected: has a first field that is equal to "3", and has a second field that is equal to "3"
Actual: ("3", "4"), whose second field does not match
out/llvm-project/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1311
Value of: Collector.diagVersions().back()
Expected: has a first field that is equal to "3", and has a second field that is equal to "3"
Actual: ("2", "3"), whose first field does not match
out/llvm-project/clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:1318
Value of: Collector.diagVersions().back()
Expected: has a first field that is equal to "3", and has a second field that is equal to "3"
Actual: ("3", "4"), whose second field does not match
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158566
Files:
llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
Index: llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
+++ llvm/test/tools/llvm-objcopy/ELF/strip-preserve-atime.test
@@ -1,7 +1,7 @@
# Note: ls -lu prints the accessed timestamp
# NetBSD: noatime mounts currently inhibit 'touch -a' updates
# Windows: the last access time is disabled by default in the OS
-# UNSUPPORTED: system-netbsd, system-windows
+# UNSUPPORTED: system-netbsd, system-windows, system-darwin
# Preserve dates when stripping to an output file.
# RUN: yaml2obj %s -o %t.1.o
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158566.552540.patch
Type: text/x-patch
Size: 642 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230823/dd917a3f/attachment.bin>
More information about the llvm-commits
mailing list