[PATCH] D157077: [RISCV] Teach VSETVLIInserter to not demand tail policy when there is no tail element

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 13:54:59 PDT 2023


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: sunshaoce.

Taking a step back from the code, can you say a little about the motivation for this?  I don't see anything particularly compelling in the test diffs.  Why do you think this is an interesting optimization to implement?

Also, you definitely need more meaningful test coverage before this is reviewable.  However, let's start with the motivation as I don't want to waste your time on writing tests if we're going to end up taking a different approach anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157077/new/

https://reviews.llvm.org/D157077



More information about the llvm-commits mailing list