[PATCH] D158081: [IR] Add writable attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8107
     A.removeAttrs(getIRPosition(), AttrKinds);
+    // FIXME: Remove writable attribute if necessary.
     return A.manifestAttrs(getIRPosition(),
----------------
@jdoerfert What would be the correct way to remove an attribute from all parameters here?

In practice just the handling above seems to be enough, but it would be cleaner to explicitly remove writable if we infer readonly here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158081/new/

https://reviews.llvm.org/D158081