[PATCH] D158504: [RISCV][GlobalISel] Select G_CONSTANT

Nitin John Raj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 13:20:00 PDT 2023


nitinjohnraj added a comment.

In order to add s32 tests for rv64 we need to select for G_ANYEXT instructions (to return the s32 constant).



================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/constant64.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=riscv64 -run-pass=instruction-select %s -o - \
----------------
craig.topper wrote:
> craig.topper wrote:
> > Need s32/i32 tests too since i32 is legal on RV64.
> Did you miss this comment?
Sorry, was still working on this when I submitted, I forgot to change the status of the issue. 
In order to return the constant, I need to select G_ANYEXT as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158504/new/

https://reviews.llvm.org/D158504



More information about the llvm-commits mailing list