[PATCH] D158527: [InstCombine] Remove calls to getOrEnforceKnownAlignment in LoadInst and StoreInst

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Thinking about how to stage these changes: I think ideally, we should add a `cl::opt` that controls whether a) the InferAlignment pass is enabled in PassBuilderPipelines and b) alignment inference in InstCombine is disabled. Then we can first land the new pass without enabling it, and then we can flip the switch to effectively switch from inference in InstCombine to the new pass. This will make it clear what the test impact (outside InstCombine) is. E.g. this patch currently fails clang tests, and it would be nice to see that those failures aren't present when the new pass is enabled at the same time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158527/new/

https://reviews.llvm.org/D158527