[PATCH] D158504: [RISCV][GlobalISel] Select G_CONSTANT

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 12:21:54 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp:134
+                          : FinalReg;
+    RISCVMatInt::Inst I = Seq[i];
+    MachineInstr *Result;
----------------
`const RISCVMatInt::Inst &I`


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/constant64.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=riscv64 -run-pass=instruction-select %s -o - \
----------------
Need s32/i32 tests too since i32 is legal on RV64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158504/new/

https://reviews.llvm.org/D158504



More information about the llvm-commits mailing list