[PATCH] D158465: [AMDGPU] Rename 64BitDPP feature and fix the checks

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 10:33:23 PDT 2023


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:457
 
-def Feature64BitDPP : SubtargetFeature<"dpp-64bit",
-  "Has64BitDPP",
+def FeatureDPALU_DPP : SubtargetFeature<"dpp-64bit",
+  "HasDPALU_DPP",
----------------
Joe_Nash wrote:
> nit: Call it "DP_ALU_DPP" instead of "DPALU_DPP" because DP and ALU are acronyms in their own right?
Our documentation refers to it as DPALU or DPMACC, so I' prefer not to produce more underscores.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158465/new/

https://reviews.llvm.org/D158465



More information about the llvm-commits mailing list