[PATCH] D158355: [X86][CodeGen] Add a dag pattern to fix #64323
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 09:43:24 PDT 2023
goldstein.w.n added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:21714
+ return DAG.getNode(ISD::TRUNCATE, DL, ScalarVT, InOp);
+ else if (InOp.getValueType().bitsLE(ScalarVT))
+ return DAG.getNode(ISD::ANY_EXTEND, DL, ScalarVT, InOp);
----------------
pengfei wrote:
> Do not use `else` when the previous condition ends with `return`.
you can also just remove second `if` entirely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158355/new/
https://reviews.llvm.org/D158355
More information about the llvm-commits
mailing list