[PATCH] D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 09:19:00 PDT 2023
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
LGTM from my viewpoint if a PowerPC reviewer looks ok as well.
================
Comment at: lld/test/ELF/ppc64-tls-pcrel-ie.s:52
+# IE-RELOC: 00000000010100f0 0000000100000049 R_PPC64_TPREL64 0000000000000000 x + 0
+# IE-RELOC: 00000000010100f8 0000000200000049 R_PPC64_TPREL64 0000000000000000 y + 0
----------------
This line can use `-NEXT:`
================
Comment at: lld/test/ELF/ppc64-tls-pcrel-ie.s:64
+# LE-SYM: Symbol table '.symtab' contains 14 entries:
+# LE-SYM: 12: 0000000000000000 0 TLS GLOBAL DEFAULT 12 x
+# LE-SYM: 13: 0000000000000004 0 TLS GLOBAL DEFAULT 12 y
----------------
The symbol indexes are not so reliable if we change the symbol table order in the future.
Omit the section indexes as well.
```
# LE-SYM: 0000000000000000 0 TLS GLOBAL DEFAULT [[#]] x
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158197/new/
https://reviews.llvm.org/D158197
More information about the llvm-commits
mailing list