[PATCH] D158081: [IR] Add writable attribute
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 07:45:23 PDT 2023
nikic added a comment.
Something I'm concerned about is the interaction between writable and readonly, as well as `memory(argmem: read)`. The way this is specified right now, `writable readonly` is immediate UB. And I think that's semantically correct.
However, I think it would be a good idea to make things like `writable readonly` a verifier error instead. This will make sure that passes like FuncAttrs remove the writable attribute when inferring readonly (which this patch currently fails to do). I assume we prefer having readonly over writable, as in the cases where we can infer readonly we wouldn't be interested in inserting spurious stores anyway.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158081/new/
https://reviews.llvm.org/D158081
More information about the llvm-commits
mailing list