[PATCH] D158068: [DAG] FoldSetCC - add missing icmp(X,undef) -> isTrueWhenEqual case

Tue Aug 22 07:07:54 PDT 2023

RKSimon added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/p10-spill-crgt.ll:423
   %tmp12 = icmp eq i32 %tmp11, 512
   switch i32 undef, label %bb13 [
     i32 117, label %bb62
----------------
arsenm wrote:
> RKSimon wrote:
> > nikic wrote:
> > > Don't switch on undef...
> > @amyk This is the original test case from D87705 - can you recall the background to why these tests use switch on undef?
> I’m sure most are because it’s what bugpoint does 
Does anyone have any objections to the codegen change in test? Its likely that the new fold is affecting the test's usefulness (but that isn't that unusual for reduction) - ideally we'd re-run bugpoint with this patch in place, but I'm not sure if that's viable?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158068/new/

https://reviews.llvm.org/D158068