[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

Tue Aug 22 05:48:24 PDT 2023

aaron.ballman added a comment.

In D155579#4604541 <https://reviews.llvm.org/D155579#4604541>, @mstorsjo wrote:

> In D155579#4604241 <https://reviews.llvm.org/D155579#4604241>, @aganea wrote:
>
>> One option like I was suggesting would be to hide this new behavior behind a (disabled) option, and tell users about it. But I'm not sure how useful it would be.
>
> Yeah that's probably not too useful in the long run. When you hit this issue, you get extremely confusing error behaviours, to the point that I believe we can't diagnose and suggest the option to the user. I wouldn't expect any regular user to figure out to enable the option really. So whatever we do, it should probably work pretty much automatically.

Agreed, I don't think an option really helps all that much.

> You who might have more use of nontrivial Windows build scenarios - how much impact would it be to go all in on the new path canonicalization + hash approach, i.e. ditching the file index entirely? Performance wise I would believe that it would be no significant change to before. The only thing that matters probably is how it behaves wrt symlinks/hardlinks, if those are present and in use.

A related question for hashes -- what about case insensitivity of file paths and slash direction? Presumably we want `F:\foo\Bar` to be the same path as `F:/FOO/BAR`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579