[PATCH] D156103: [AMDGPU][NFC] Add True16 operand definitions.
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 05:09:11 PDT 2023
kosarev added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:1460
}
if (Val <= SGPR_MAX) {
// "SGPR_MIN <= Val" is always true and causes compilation warning.
----------------
Joe_Nash wrote:
> Is it intentional that you're not calling decodeNonVGPRSrcOp here and instead duplicating parts of the function?
Good catch. This is an oversight.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156103/new/
https://reviews.llvm.org/D156103
More information about the llvm-commits
mailing list