[PATCH] D158490: [AArch64] Disable GlobalISel/FastISel for more SME functions
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 22 00:06:51 PDT 2023
dmgreen created this revision.
dmgreen added reviewers: sdesmalen, aemerson, david-arm, CarolineConcatto.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a project: LLVM.
The patch D136361 <https://reviews.llvm.org/D136361> disabled GlobalISel and FastISel for some SME functions, as the saving and restoring of SM is not yet handled. There were several tests added for fp128 fadd, which will be expanded to a libcall, that only happened to work by accident and did not handle other cases such as f32/f64 frem libcalls.
This extends the cases where GlobalISel / FastISel is disabled for functions with SME attributes, under the assumption that it is difficult to tell what will become a libcall reliably, and so should fall back for all function until GlobalISel and/or FastISel can handle them.
https://reviews.llvm.org/D158490
Files:
llvm/lib/Target/AArch64/AArch64FastISel.cpp
llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
llvm/test/CodeGen/AArch64/sme-disable-gisel-fisel.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158490.552233.patch
Type: text/x-patch
Size: 10488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230822/399eb523/attachment.bin>
More information about the llvm-commits
mailing list