[PATCH] D145819: [FuncSpec] Increase the maximum number of times the specializer can run.

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 23:20:55 PDT 2023


ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

The patch itself looks pretty simple and the numbers look good too. So I think there may not be reason to block this.



================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:869-871
+      unsigned &CodeSizeGrowth = FunctionGrowth[F];
+      CodeSizeGrowth += FuncSize - B.CodeSize;
+      if (CodeSizeGrowth / FuncSize > MaxCodeSizeGrowth)
----------------
It looks a little better to remove the variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145819/new/

https://reviews.llvm.org/D145819



More information about the llvm-commits mailing list