[PATCH] D158466: [NFC][Profile] Rename Counters/DataSize to NumCounters/Data

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added a subscriber: leonardchan.
mcgrathr added a comment.

In D158466#4605086 <https://reviews.llvm.org/D158466#4605086>, @aeubanks wrote:

> @phosek @mcgrathr I'm worried that compatibility guarantees of this header weren't properly considered when it was exposed in https://reviews.llvm.org/D64532 and that it'll make changes to this harder, making the upstream burden higher than desired.

Users of this file are aware of the lack of compatibility guarantees.  We are prepared to update our code that relies on the details in this file when it changes upstream.

For the much longer term, @leonardchan and others will be exploring how to expose the runtime implementation details needed for custom runtimes in more maintainable ways than referring to this internal header. But for the foreseeable future, to continue to maintain the custom runtimes we are already maintaining, we've found that exposing this file and adapting to its upstream changes is far better than the alternative of sharing no code with upstream and still having to track such changes when they are material and not only cosmetic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158466/new/

https://reviews.llvm.org/D158466