[PATCH] D157068: [Attributor] New attribute to identify what byte ranges are alive for an allocation

[Vidhush Singhal via Phabricator via llvm-commits]

vidsinghal added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:12517
+        !AI->getAllocatedType()->getContainedType(0)->isVectorTy())
+      return indicatePessimisticFixpoint();
+
----------------
jdoerfert wrote:
> Why do you give up on struct type like `{i32, i32}`?
> I don't understand why we need this conditional at all.
I was trying to indicate a fix point for structs like 
type S = {ptr}
where the struct has only one element in it. 
But I think that OffsetEnd == AllocationSize check should work for this now (after fixing the size of pointer issue) I'll remove this check. 
Previously this was not working which is why I had to had this check and i think 
getNumContainedTypes should have been getStructNumElements instead. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157068/new/

https://reviews.llvm.org/D157068