[PATCH] D99205: Add jump-threading optimization for deterministic finite automata

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 10:48:43 PDT 2023


nlopes added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DFAJumpThreading.cpp:1143
+      for (PHINode *PN : PhiToRemove) {
+        PN->replaceAllUsesWith(UndefValue::get(PN->getType()));
+        PN->eraseFromParent();
----------------
please use a poison value as placeholder instead of undef.
We are trying to remove undef.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99205/new/

https://reviews.llvm.org/D99205



More information about the llvm-commits mailing list