[PATCH] D158440: [DXILBitcodeWriter] Don't create a new abbrev per MDString

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 10:30:47 PDT 2023


bogner created this revision.
bogner added reviewers: beanz, bob80905, python3kgae.
Herald added subscribers: hiraditya, mcrosier.
Herald added a project: All.
bogner requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were running out of abbrevs and crashing if there were more than 20
something strings in metadata, which turned out to be a bug where we
created an abbrev every time we emitted a string rather than just one
for the string table.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158440

Files:
  llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
  llvm/test/tools/dxil-dis/md-manystrings.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158440.552073.patch
Type: text/x-patch
Size: 3422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230821/f6c23482/attachment.bin>


More information about the llvm-commits mailing list