[PATCH] D158161: [RISCV] Don't relax policy to ta when vmerge's VL shrinks during folding

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 10:27:24 PDT 2023


reames added a comment.

In D158161#4604128 <https://reviews.llvm.org/D158161#4604128>, @reames wrote:

> LGTM.  Sorry, should have done that Friday.

I sat down and did the case analysis for all 9 combinations of policy states.  We disallow certain combinations via early returns, and I believe that with this patch, all the other cases are covered correctly.

I think this might be a case where generalizing to handle the remaining cases actually simplifies and makes the code more obvious, but that's definitely a future patch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158161/new/

https://reviews.llvm.org/D158161



More information about the llvm-commits mailing list